Skip to content

Add a Monoid instance for Parser #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomashoneyman merged 1 commit into from
Sep 13, 2020
Merged

Add a Monoid instance for Parser #58

thomashoneyman merged 1 commit into from
Sep 13, 2020

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Sep 13, 2020 •
edited
Loading

What does this pull request do?

Fixes #33

Note: this doesn't implement Foldable for Parser, which is the other part of that issue.

@thomashoneyman
Copy link
Contributor

thomashoneyman commented Sep 13, 2020

Thanks! I'm not sure a Foldable instance makes much sense for Parser; this PR at least does enable the use case of calling fold on an a array of parsers, though, which is nice.

@thomashoneyman thomashoneyman merged commit 54ba93e into purescript-contrib:main Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Foldable, monoid for parser

2 participants

@JordanMartinez @thomashoneyman