Skip to content

Conversation

@theqp
Copy link
Contributor

@theqp theqp commented Sep 24, 2021

This is a breaking change.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@thomashoneyman
Copy link
Contributor

@garyb I see the 👍 -- is this something we want to standardize on? The foreign-import object going last?

@garyb
Copy link
Member

garyb commented Sep 27, 2021

Not so much the foreign-import object going last as "the thing being operated on", as that's the convention generally everywhere - collections, refs, is (should) be the case with the other web libraries, etc. 🙂

@thomashoneyman thomashoneyman added the type: breaking change A change that requires a major version bump. label Sep 27, 2021
@JordanMartinez
Copy link
Contributor

Is this another breaking change to make in v0.15.0?

@JordanMartinez JordanMartinez added the purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 label Mar 25, 2022
@thomashoneyman
Copy link
Contributor

Let's do it!

@JordanMartinez JordanMartinez merged commit 1099958 into purescript-web:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants