Fix type of Web.HTML.Window.(scrollX|scrollY) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Friendly bump :) |
hdgarrood
approved these changes
Feb 23, 2020
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Sorry for the lack of responsiveness. Since this is a breaking change, we generally try to bunch those up together across libraries which are used by a lot of the ecosystem, so I think we will probably want to publish this alongside all of the other breaking changes we're going to make for version 0.14.0 of the compiler.
thomashoneyman
added
the
purs-0.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scrollY and scrollX in
Web.HTML.Window- these functions can return subpixel values on scaled screens.This intends to close #16