-
Notifications
You must be signed in to change notification settings - Fork 24
img attrs: srcset, currentSrc, sizes, referrerPolicy, decoding, loading #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
garyb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these, but can we introduce sum types for all the stringy attributes that only actually have a set of acceptable values? CanPlayType in this repo would be an existing example of that.
|
I wouldn't disagree, but it seemed like a lot of the APIs exposed in this repo are just stringly-typed. Can do though. |
|
I think |
fa818b1 to
7ab3f78
Compare
thomashoneyman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though I would appreciate another look from @garyb.
| "lazy" -> Just Lazy | ||
| _ -> Nothing | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
All seems reasonable to me! Thanks for adding those sums. |
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Description
Adding missing attributes for
HTMLImagehttps://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-currentsrc
It would be nice to include
decode(), but since it returns aPromiseand this project doesn't includeAff, I skipped it.