Skip to content

Conversation

@jmp-0x7C0
Copy link
Contributor

@jmp-0x7C0 jmp-0x7C0 commented Aug 19, 2022

Prerequisites

  • Before opening a pull request, please check the HTML standard (https://dom.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description of the change

According to the WHATWG HTML Living Standard, Window should have a close method: window.close(), which has been added in this PR.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JordanMartinez JordanMartinez merged commit 7befd15 into purescript-web:master Aug 23, 2022
@jmp-0x7C0 jmp-0x7C0 deleted the windowclose branch August 23, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants