Skip to content

Add errorWithCause constructor #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanMartinez merged 3 commits into from
Dec 22, 2022
Merged

Add errorWithCause constructor #43

JordanMartinez merged 3 commits into from
Dec 22, 2022

Conversation

@sigma-andex
Copy link
Contributor

@sigma-andex sigma-andex commented Dec 20, 2022

Description of the change

Add errorWithCause constructor for creating Errors with a cause.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#rethrowing_an_error_with_a_cause

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

garyb
garyb approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Dec 22, 2022

@sigma-andex can you add the missing semicolon?

@JordanMartinez JordanMartinez merged commit e110d79 into purescript:master Dec 22, 2022
@sigma-andex sigma-andex deleted the add-error-with-cause branch December 22, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyb garyb garyb approved these changes

+1 more reviewer

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sigma-andex @JordanMartinez @garyb