fix: keyword only non default argument #1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1290 will not alter performanceComparing Summary
|
JeanArhancet
force-pushed
the
fix/keyword-only-non-default-argument
branch
from
8889628 to
0ace46a
Compare
Contributor
Author
|
please review |
davidhewitt
reviewed
May 16, 2024
Contributor
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this change makes sense to me. It looks like we'll have to update pydantic to feed in this new keyword_only mode?
Contributor
Author
|
@davidhewitt If I'm not mistaken, Pydantic already passes the |
davidhewitt
approved these changes
May 18, 2024
Contributor
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Right yes, sorry I had missed that!
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
Original-commit-hash: b777774
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix keyword only non default argument
Related issue number
fix pydantic/pydantic#9337
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @davidhewitt