Skip to content

Conversation

@davidhewitt
Copy link
Contributor

Change Summary

Supersedes #1276, using a new PyO3 0.22 API to get the full type name.

Related issue number

Closes pydantic/pydantic#7911

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@sydney-runkle
Copy link
Contributor

I'm ok with this, but this is potentially a breaking change for some folks, so let's wait until the next minor release (tomorrow or Wednesday probably), so that we can chat about this before merging.

@sydney-runkle
Copy link
Contributor

I'm guessing it would generally only break tests, but still...

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 24, 2024

CodSpeed Performance Report

Merging #1342 will not alter performance

Comparing dh/full-type-names (9abbdfa) with main (7b62646)

Summary

✅ 155 untouched benchmarks

@davidhewitt davidhewitt marked this pull request as ready for review June 25, 2024 09:02
@samuelcolvin
Copy link
Member

Personally I'm 👎 for this, I think it'll be a significant breaking change for lots of people because of tests, I also think it's a bit uglier for little gain.

@sydney-runkle
Copy link
Contributor

Closing for now, given the above comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation error does not indicate type

4 participants