Skip to content

Conversation

@sydney-runkle
Copy link
Contributor

When using a custom serializer, we had an internal schema generation bug where we weren't storing the associated schema in definitions when creating a definitions reference schema.

Fix #9394

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 21, 2024
@cloudflare-workers-and-pages
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 196971a
Status: ✅  Deploy successful!
Preview URL: https://14ead29a.pydantic-docs.pages.dev
Branch Preview URL: https://fix-key-err.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #10200 will not alter performance

Comparing fix-key-err (196971a) with main (ada82d5)

Summary

✅ 17 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py ImageImageImageImage
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 484ae83 into main Aug 21, 2024
@sydney-runkle sydney-runkle deleted the fix-key-err branch August 21, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serializing computed fields returning enums

3 participants