Simplify unions involving Any or Never when replacing type variables
#10338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
force-pushed
the
simplify-any-never-unions
branch
from
f4d6be3 to
9097bd2
Compare
Deploying pydantic-docs with
|
| Latest commit: |
9097bd2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcd106ae.pydantic-docs.pages.dev |
| Branch Preview URL: | https://simplify-any-never-unions.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10338 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Sep 10, 2024
Contributor
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the inline comments, makes this super easy to review / understand for future devs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I could have implemented this simplification for all cases (perhaps in
GenerateSchema._apply_single_annotationor similar) but I don't want to break any unusual scenarios, plus this kind of situation is pretty uncommon in the general case (you're not really going to annotate a field asAny | <other>), it only makes sense when parameterizingT | <other>withAny/Never.This has the added benefit of creating simplified JSON Schemas, as shown in the test.
Related issue number
Checklist