Expose public sort method for JSON schema generation
#10595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
12cc428
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://756056c8.pydantic-docs.pages.dev |
| Branch Preview URL: | https://sorting-for-good-hopefully.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10595 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Co-authored-by: Victorien <[email protected]>
adriangb
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7580
At first, thought we might have to add a flag to fix this. The way I feel about adding flags at this point is about how edna (from The Incredibles) feels about capes.
Luckily, was able to sidestep the need for a flag by exposing the sort method as a public one in the
GenerateJsonSchemaclass.Did a little bit of refactoring to make things more type checking friendly re the outer sort vs recursive sorts. I did the move -> public and refactoring in different commits, so should be easy to review. Also added a docs example to expose the customizability here. Yay for empowered users!