Skip to content

Conversation

@Daraan
Copy link
Contributor

@Daraan Daraan commented Oct 25, 2024

Change Summary

Added support for recent typing_extensions.TypeAliasType from python/typing_extensions#477 that cause tests to fail currently.

Related issue number

fix #10711

python/typing_extensions#493

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 25, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #10713 will not alter performance

Comparing Daraan:TypeAliasType-backport (373dddd) with main (12f89be)

Summary

✅ 44 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _core_utils.py ImageImageImageImage
  _generate_schema.py ImageImageImageImage
  _typing_extra.py ImageImageImageImage604
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

@Daraan Daraan marked this pull request as ready for review October 25, 2024 14:21
@Daraan
Copy link
Contributor Author

Daraan commented Oct 25, 2024

please review

@Viicos
Copy link
Member

Viicos commented Oct 25, 2024

Thanks for the investigation and for the PR. I had this issue in my mind for some time now, and actually there's some other places where we're not careful enough (e.g. is Any checks). Is it fine if I tackle everything in a single PR, adding you as a co-author?

@Daraan
Copy link
Contributor Author

Daraan commented Oct 25, 2024

Thanks for the investigation and for the PR. I had this issue in my mind for some time now, and actually there's some other places where we're not careful enough (e.g. is Any checks). Is it fine if I tackle everything in a single PR, adding you as a co-author?

Sure thing!

@JelleZijlstra
Copy link
Contributor

@Viicos I'd appreciate if this gets merged relatively quickly so the daily typing-extensions workflow that runs the pydantic test suite starts passing again. (Of course there are other workarounds; we could temporarily disable the pydantic tests, or just close the issue every day.)

@Viicos
Copy link
Member

Viicos commented Oct 25, 2024

Ah didn't know that, I'll merge immediately and rebase on my working branch!

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daraan

@Viicos Viicos changed the title Differentiate between typing & recent typing_extensions.TypeAliasType backport for Python 3.12, 3.13 Properly check for typing_extensions variant of TypeAliasType Oct 25, 2024
@Viicos Viicos merged commit 13979e9 into pydantic:main Oct 25, 2024
52 checks passed
@Daraan Daraan deleted the TypeAliasType-backport branch October 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recent typing_extensions.TypeAliasType backport causing tests to fail.

4 participants