Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Nov 10, 2024

Change Summary

Many thanks @kc0506 for the implementation.

Closes #10624, fixes #8984, seems like it fixes #8317.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 10, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07e5b51
Status: ✅  Deploy successful!
Preview URL: https://e2cd6db8.pydantic-docs.pages.dev
Branch Preview URL: https://fix-typealias.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #10809 will not alter performance

Comparing fix-typealias (07e5b51) with main (c7a3d5c)

Summary

✅ 44 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _core_utils.py ImageImageImageImage
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this across the finish line, @Viicos!

@sydney-runkle sydney-runkle merged commit ff4a325 into main Nov 12, 2024
56 checks passed
@sydney-runkle sydney-runkle deleted the fix-typealias branch November 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pydantic_core._pydantic_core.SchemaError: Definitions error: definition XYZ was never filled Error with double wrapping TypeAliasType

4 participants