Skip to content

Use uv run consistently in Makefile #11353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Viicos merged 7 commits into from
Jan 31, 2025
Merged

Use uv run consistently in Makefile #11353

Viicos merged 7 commits into from
Jan 31, 2025

Conversation

@jaceklaskowski
Copy link
Contributor

@jaceklaskowski jaceklaskowski commented Jan 28, 2025 •
edited
Loading

Use uv run pre-commit in Makefile (as uv run ruff).

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11353 will not alter performance

Comparing jaceklaskowski:makefile-pre-commit-uvx (3fdb456) with main (8fe3aae)

Summary

✅ 45 untouched benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Coverage report

Image Image

This PR does not seem to contain any modification to coverable code.

Viicos
Viicos requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. uvx is not equivalent to uv run, but uv tool run

@jaceklaskowski jaceklaskowski requested a review from Viicos January 30, 2025 18:10
@jaceklaskowski jaceklaskowski changed the title build: uvx pre-commit in Makefile build: uv run pre-commit in Makefile Jan 30, 2025
@Viicos Viicos changed the title build: uv run pre-commit in Makefile Use uv run consistently in Makefile Jan 31, 2025
@Viicos Viicos added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels Jan 31, 2025
@Viicos Viicos merged commit 1893af0 into pydantic:main Jan 31, 2025
53 checks passed
@jaceklaskowski jaceklaskowski deleted the makefile-pre-commit-uvx branch February 2, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

No one assigned

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaceklaskowski @Viicos