Skip to content

Fix path serialization behavior #11416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 2 commits into from
Feb 7, 2025
Merged

Fix path serialization behavior #11416

sydney-runkle merged 2 commits into from
Feb 7, 2025

Conversation

@sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Feb 7, 2025

Fix #11245

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Feb 7, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e8ffc1
Status: ✅  Deploy successful!
Preview URL: https://1c51fb0e.pydantic-docs.pages.dev
Branch Preview URL: https://fix-path-ser.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle mentioned this pull request Feb 7, 2025
Closed
1 task
@sydney-runkle sydney-runkle requested a review from Viicos February 7, 2025 17:37
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11416 will improve performances by 5.08%

Comparing fix-path-ser (4e8ffc1) with main (044d685)

Summary

⚡ 1 improvements
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_north_star_json_loads 19.1 ms 18.2 ms +5.08%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic/_internal
  _generate_schema.py ImageImageImageImage
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 61feb99 into main Feb 7, 2025
54 checks passed
@sydney-runkle sydney-runkle deleted the fix-path-ser branch February 7, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Different dump behaviour for a field declared as “Path | list[Path]” vs “list[Path] | Path”

3 participants

@sydney-runkle @Viicos