-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add support for validating v6, v7, v8 UUIDs #11436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please review |
|
CI failures look to be expected due to the dependent pydantic-core change |
CodSpeed Performance ReportMerging #11436 will not alter performanceComparing Summary
|
|
Thanks for the contribution. Could we also add version 6 and 8? |
|
@Viicos I'm happy to do so, but this will require an additional change in |
|
Thanks, that would be great. |
|
This looks great, thanks for the contribution! |
|
I have added the v6/v8 support, as well as opening pydantic/pydantic-core#1636 to add the required support within |
|
Perfect! When we do a |
Co-authored-by: Sydney Runkle <[email protected]>
First-time contributor. I think this change is still ultimately trivial, even though it also requires a change in
pydantic-coretoo (since that's where the UUID validation logic lives).Change Summary
Adds support for validating v6, v7, and v8 UUIDs. These versions are defined in RFC 9562. To pluck some really low-hanging fruit, implement support for it in pydantic.
Depends on pydantic/pydantic-core#1634 (UUIDv7), pydantic/pydantic-core#1636 (v6 / v8)
Related issue number
n/a
Checklist
Selected Reviewer: @sydney-runkle