Make sure Pydantic dataclasses with slots and validate_assignment can be unpickled
#11769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
4cf3a25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28d9942a.pydantic-docs.pages.dev |
| Branch Preview URL: | https://dc-slots-validate-assignment.pydantic-docs.pages.dev |
Viicos
force-pushed
the
dc-slots-validate-assignment
branch
from
63c9727 to
d174f8b
Compare
CodSpeed Performance ReportMerging #11769 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
DouweM
requested changes
Apr 25, 2025
Contributor
DouweM
left a comment
DouweM
left a comment
There was a problem hiding this comment.
@Viicos Take my comments with a grain of salt because you've looked into this much more deeply than I have, but I was confused about a few things which may point at real issues/opportunities for improvement. But if not, let me know and I'll defer to your judgment and merge this :)
pydantic-hooky
bot
added
the
awaiting author revision
DouweM
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11768.
Change Summary
Related issue number
Checklist