Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Apr 18, 2025

Change Summary

Fixes #11748. Although this bug was present since v2.0, it manifested in a hard failure since 2.11, so we'll backport it.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added backport-2.11 relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests labels Apr 18, 2025
@Viicos Viicos closed this Apr 18, 2025
@Viicos Viicos reopened this Apr 18, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 18, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: eda3702
Status: ✅  Deploy successful!
Preview URL: https://815726a0.pydantic-docs.pages.dev
Branch Preview URL: https://recursive-gen.pydantic-docs.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py ImageImageImageImage
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 18, 2025

CodSpeed Performance Report

Merging #11775 will not alter performance

Comparing recursive-gen (eda3702) with main (bf06866)

Summary

✅ 46 untouched benchmarks

@DouweM DouweM merged commit 455b436 into main Apr 28, 2025
89 checks passed
@DouweM DouweM deleted the recursive-gen branch April 28, 2025 18:53
Viicos added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RootModel with Generics with self-referencing fails to compile

3 participants