Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Jun 4, 2025

This applying roughly the same logic from #11388 for dataclasses.

Fixes #11947.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 labels Jun 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #11949 will not alter performance

Comparing rebuild-dataclass-fields (9995ef8) with main (e1f9d15)

Summary

✅ 46 untouched benchmarks

@Viicos Viicos force-pushed the rebuild-dataclass-fields branch from 158a17d to fc1858d Compare June 4, 2025 14:30
@Viicos Viicos added the third-party-tests Add this label on a PR to trigger 3rd party tests label Jun 4, 2025
@Viicos Viicos closed this Jun 4, 2025
@Viicos Viicos reopened this Jun 4, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9995ef8
Status:⚡️  Build in progress...

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Coverage report

Image Image

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  dataclasses.py ImageImageImageImage
  pydantic/_internal
  _fields.py ImageImageImageImage
  _generate_schema.py ImageImageImageImage
Project Total ImageImageImageImage 

This report was generated by python-coverage-comment-action

This applying roughly the same logic from #11388
for dataclasses.
@Viicos Viicos force-pushed the rebuild-dataclass-fields branch from fc1858d to e8a3c45 Compare June 12, 2025 15:04
@Viicos Viicos force-pushed the rebuild-dataclass-fields branch from f0e5089 to 9995ef8 Compare June 12, 2025 19:18
@Viicos Viicos merged commit 43bbdc0 into main Jun 12, 2025
86 of 87 checks passed
@Viicos Viicos deleted the rebuild-dataclass-fields branch June 12, 2025 19:25
Viicos added a commit that referenced this pull request Jun 12, 2025
Viicos added a commit that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.11.0 fails to resolve forward ref (future annotation)?

3 participants