Skip to content

Conversation

@PrettyWood
Copy link
Collaborator

@PrettyWood PrettyWood commented May 14, 2021

Change Summary

Tiny bug spotted when working on another PR.

Related issue number

closes #3119

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@PrettyWood PrettyWood force-pushed the fix/nested_literal_with_constraints branch from 1c6c12d to 624a377 Compare May 14, 2021 11:55
@PrettyWood
Copy link
Collaborator Author

Please review 🙇

@PrettyWood PrettyWood merged commit 6b61160 into pydantic:master Sep 4, 2021
@PrettyWood PrettyWood deleted the fix/nested_literal_with_constraints branch September 4, 2021 02:36
jpribyl pushed a commit to liquet-ai/pydantic that referenced this pull request Oct 7, 2021
* fix: nested literal with constraints

* docs: add change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passing max_items in Field with a List[Literal["something"] field raises TypeError

2 participants