Skip to content

mention 3.8 requirement in contrib docs #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PrettyWood merged 3 commits into from
Sep 4, 2021
Merged

mention 3.8 requirement in contrib docs #2856

PrettyWood merged 3 commits into from
Sep 4, 2021

Conversation

@paxcodes
Copy link
Contributor

@paxcodes paxcodes commented May 28, 2021 •
edited
Loading

Change Summary

Mention 3.8 requirement in contrib docs. Using python3.7 to build docs will fail:

-> % make docs      
flake8 --max-line-length=80 docs/examples/
docs/examples/validation_decorator_parameter_types.py:26:34: E999 SyntaxError: invalid syntax
make: *** [docs] Error 1

Where validation_decorator_parameter_types.py:26:34 has def pos_only(a: int, b: int = 2, /) -> str: # python 3.8 only

Checklist

  • [n/a; docs change] Unit tests for the changes exist
  • [n/a; docs change] Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@paxcodes paxcodes marked this pull request as ready for review May 28, 2021 22:31
@paxcodes
Copy link
Contributor Author

paxcodes commented May 28, 2021

please review

Thorbenl
Thorbenl approved these changes Jun 2, 2021
View reviewed changes
Copy link

@Thorbenl Thorbenl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

PrettyWood
PrettyWood requested changes Jun 4, 2021
View reviewed changes
@PrettyWood
Copy link
Collaborator

PrettyWood commented Jun 4, 2021

Please update and rebase/merge with master

@github-actions github-actions bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jun 4, 2021
@github-actions github-actions bot assigned paxcodes and unassigned samuelcolvin and PrettyWood Jun 4, 2021
@paxcodes paxcodes force-pushed the update_python_version_in_contrib_docs branch from d1e3f7e to e7f041a Compare June 12, 2021 17:50
@paxcodes paxcodes requested a review from PrettyWood June 12, 2021 17:52
@paxcodes
Copy link
Contributor Author

paxcodes commented Jul 14, 2021

please review

@github-actions github-actions bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 14, 2021
@github-actions github-actions bot assigned PrettyWood and samuelcolvin and unassigned paxcodes Jul 14, 2021
PrettyWood
PrettyWood approved these changes Sep 4, 2021
View reviewed changes
Copy link
Collaborator

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PrettyWood PrettyWood merged commit 4ac2501 into pydantic:master Sep 4, 2021
jpribyl pushed a commit to liquet-ai/pydantic that referenced this pull request Oct 7, 2021
@paxcodes @jpribyl
mention 3.8 requirement in contrib docs (pydantic#2856)
28009c5 
* mention 3.8 requirement in contrib docs

* add change.md for PR#2856

* docs: fix grammar and wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

+1 more reviewer

@Thorbenl Thorbenl Thorbenl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels

documentation ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paxcodes @PrettyWood @Thorbenl @samuelcolvin