Fix support for using a subclass of an annotation as a default #3018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
A field can be set with a default that is a subclass of the type hint when set together:
Additionally, a model can be instantiated with a subclass of the type hint:
Simple(x=MyStr("works")).However, when using model subclasses where the base sets a type hint, but the default (eg:
MyStr) is set in asubclass, the
The type of {name}.{var_name} differs from the new default valueexception is raised:I think rather than checking for an exact match on the type, we should be able to use
lenient_issubclass. This seems pretty sane and didn't break any of the existing tests. My use case is actually using anAnnotation(BaseModel)as the type hint, but setting subclass defaults likeVendor(Annotation), but that should follow from this simpler test case.Related issue number
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)