improve settings priority, #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
settings-priority
branch
from
514a517 to
501d4fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 1820 1818 -2
Branches 356 356
=====================================
- Hits 1820 1818 -2 |
5 tasks
samuelcolvin
force-pushed
the
settings-priority
branch
from
501d4fe to
7ae7953
Compare
dbarrosop
reviewed
Dec 29, 2018
| s = Settings(__config_settings__=config, b='argument b', c='argument c') | ||
| assert s.a == 'config a' | ||
| assert s.b == 'argument b' | ||
| assert s.c == 'env setting c' |
There was a problem hiding this comment.
Not sure if I am misreading something but according to the docs the order of preference is class_defaults < env < arguments, however, your test is proving that class_defaults < arguments < env. I might be misreading this completely but my tests seem to confirm this.
There was a problem hiding this comment.
Ok, just realized that your test case is testing changing the order + using the __config_settings__ trick, not the default case. So all is good and I managed to get it working exactly as I wanted, thanks a lot!
samuelcolvin
force-pushed
the
settings-priority
branch
from
0b4f10f to
3c05c04
Compare
4 tasks
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
This implements support for constraining datetime objects based on them having or not having timezone info. The aware kind constrains to objects that have timezone info, and symmetrically, the naive kind constrains to objects that do not have timezone info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Improve documentation for settings priority and allow them to be more easily changed.
Related issue number
ref #341
Checklist
HISTORY.rsthas been updated#<number>@whatever