Make it work to use $ref as an alias
#6568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d05aba4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dbdb6016.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://allow-dollar-ref-alias.pydantic-docs2.pages.dev |
Contributor
Author
|
please review |
lig
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6534
Note that while there are many references to the
'$ref'key in the codebase that might otherwise appear to be subject to this issue, in most cases, there are not free-form user-specified keys in the values being handled. The exception to this are functions that are called recursively on dicts that happen to be JSON schemas. In these cases, I believe that is safe to assume that if the key is'$ref'and the value has typestr(as opposed todictetc.) then that should be a real JSON schema ref, as opposed to an incidental occurrence of the key'$ref'. This PR just starts checking the type of the value for the key'$ref'in those recursive functions.skip change file check
Selected Reviewer: @lig