Skip to content

Add section about Constrained classes to the Migration Guide #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kludex merged 6 commits into from
Jul 28, 2023
Merged

Add section about Constrained classes to the Migration Guide #6924

Kludex merged 6 commits into from
Jul 28, 2023

Conversation

@Kludex
Copy link
Member

@Kludex Kludex commented Jul 28, 2023 •
edited by pydantic-hooky bot
Loading

Selected Reviewer: @adriangb

@Kludex
Copy link
Member Author

Kludex commented Jul 28, 2023

please review

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 28, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1270143
Status: ✅  Deploy successful!
Preview URL: https://6da2bb83.pydantic-docs2.pages.dev
Branch Preview URL: https://migration-guide-constrained.pydantic-docs2.pages.dev

View logs

@Kludex Kludex force-pushed the migration-guide-constrained-types branch from 9bd8e8b to d98b8ff Compare July 28, 2023 08:04
adriangb
adriangb approved these changes Jul 28, 2023
View reviewed changes
docs/migration.md Outdated


class Model(BaseModel):
x: Annotated[int, Field(ge=0)]
Copy link
Member

@adriangb adriangb Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d make it a type alias so that it’s closer to the original example

Kludex
Kludex commented Jul 28, 2023
View reviewed changes
@Kludex Kludex enabled auto-merge (squash) July 28, 2023 08:58
Kludex
Kludex commented Jul 28, 2023
View reviewed changes
Kludex
Kludex commented Jul 28, 2023
View reviewed changes
@Kludex Kludex merged commit f01260b into main Jul 28, 2023
@Kludex Kludex deleted the migration-guide-constrained-types branch July 28, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kludex @adriangb