Skip to content

✅ Enforce behavior of private attributes having double leading underscore #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hramezani merged 1 commit into from
Sep 11, 2023
Merged

✅ Enforce behavior of private attributes having double leading underscore #7265

hramezani merged 1 commit into from
Sep 11, 2023

Conversation

@lig
Copy link
Contributor

@lig lig commented Aug 28, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Enforce behavior of private attributes having double leading underscore using a test

Related issue number

Fix #4833

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18f3e52
Status: ✅  Deploy successful!
Preview URL: https://72bdf70f.pydantic-docs2.pages.dev
Branch Preview URL: https://lig-4833.pydantic-docs2.pages.dev

View logs

@lig lig mentioned this pull request Aug 28, 2023
Closed
15 tasks
@lig lig marked this pull request as ready for review August 28, 2023 12:37
@lig
Copy link
Contributor Author

lig commented Aug 28, 2023

please review

@hramezani hramezani merged commit 132a90c into main Sep 11, 2023
@hramezani hramezani deleted the lig/4833 branch September 11, 2023 07:31
@davidhewitt davidhewitt added the relnotes-fix Used for bugfixes. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels

ready for review relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Private fields in python use dunder prefix, not __name__ pattern

5 participants

@lig @hramezani @davidhewitt @samuelcolvin