Update fields.md #7744
Merged
Update fields.md #7744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small typo here. I believe str() for the alias/vscode warning workaround ([here](pydantic#5893)) was missing.
Contributor
Author
|
please review |
sydney-runkle
approved these changes
Oct 25, 2023
Contributor
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
Once we get all of the tests passing, I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Small typo. str() was left out for the alias/vscode warning workaround.
Related issue number
#5893
Checklist
Selected Reviewer: @samuelcolvin