Skip to content

Conversation

@samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Oct 1, 2019

Change Summary

  • add prepare_field hook on Config
  • use env not aliases to define which environment variable(s) settings respects

Related issue number

#721

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #847 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files          17       17              
  Lines        3099     3124      +25     
  Branches      598      606       +8     
==========================================
+ Hits         3097     3122      +25     
  Misses          2        2
Impacted Files Coverage Δ
pydantic/main.py 100% <100%> (ø) ⬆️
pydantic/fields.py 100% <100%> (ø) ⬆️
pydantic/env_settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f4e0d...3000185. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 9a5b411 into master Oct 1, 2019
@samuelcolvin samuelcolvin deleted the settings-env branch October 1, 2019 15:32
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
* change how env variables work with settings, fix pydantic#721

* inheritance and alias warnings

* update docs

* tweak env_settings.py
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants