adds test case for unexpected discriminated union behavior

[kf-novi]

Change Summary

Adds failing test case for expected behavior in discriminated union model_dump

Related issue number

#9235

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Tests pass on CI
• Documentation reflects the changes where applicable
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[codspeed-hq]

CodSpeed Performance Report

Merging #9236 will not alter performance

_{Comparing kf-novi:discriminated-union-bug (303b868) with main (77b0e1c)}

Summary

✅ 13 untouched benchmarks

[sydney-runkle]

Thanks for adding the test case! Please remove all of the other changes made in this PR (reformatting), etc

[kf-novi]

Ah can I just do make format for that?

…

On Sat, Apr 13, 2024 at 17:22 Sydney Runkle ***@***.***> wrote: Thanks for adding the test case! Please remove all of the other changes made in this PR (reformatting), etc — Reply to this email directly, view it on GitHub <#9236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5CBQT4PIORQ4P57S3QSVG3Y5HD4ZAVCNFSM6AAAAABGE5EMHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTHAYTMNBWGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[sydney-runkle]

@kf-novi I believe so, or just revert the commit + add back the test if that doesn't work

[kf-novi]

Sorry about the dual account thing here, opened with this one and keep forgetting which one I'm using. Anyway, had to revert since my auto-formatter added a bunch of commas that ruff format doesn't remove. So, should be good now.

[sydney-runkle]

@kf-novi,

Maybe add an xfail with a link to your issue, then we can merge this?

[kfreezen]

I will do that tomorrow!

…

On Thu, Apr 18, 2024 at 17:50 Sydney Runkle ***@***.***> wrote: @kf-novi <https://github.com/kf-novi>, Maybe add an xfail with a link to your issue, then we can merge this? — Reply to this email directly, view it on GitHub <#9236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUWLA2PSYGEWXJOM6PKMLY6BS5XAVCNFSM6AAAAABGE5EMHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGU2TIMRWGY> . You are receiving this because you commented.Message ID: ***@***.***>

[sydney-runkle]

@kf-novi @kfreezen :),

Wonderful, thanks for your help here!

[sydney-runkle]

Nice, including this in the patch and hoping we can get a fix for this in 2.8