Fix bug with mypy plugin's handling of covariant typevar fields #9606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9606 will not alter performanceComparing Summary
|
1 task
sydney-runkle
approved these changes
Jun 7, 2024
Contributor
sydney-runkle
left a comment
sydney-runkle
left a comment
There was a problem hiding this comment.
Thanks for such a quick turnaround on this. Great work!
sydney-runkle
deleted the
dmontagu/fix-mypy-plugin-for-covariant-typevar-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9580 and #9581.
As noted elsewhere (including in comments in the code affected by this PR), I am not confident this is the best way to fix this bug, and I think it's suspicious that dataclasses doesn't have this issue since the pydantic mypy plugin is based on the dataclasses plugin. But I think it makes sense to just merge this and look into it more carefully/thoroughly if we continue to run into issues with typevars and/or typechecking of generic basemodels.