-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
test: increase pydantic\aliases.py coverage to 100%
#9740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase pydantic\aliases.py coverage to 100%
#9740
Conversation
CodSpeed Performance ReportMerging #9740 will not alter performanceComparing Summary
|
sydney-runkle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlessandroMiola,
Thanks for your contribution here!
Could we extract this logic into a separate test, maybe called test_search_dict_for_path or something similar? I think that'll help to keep things organized.
Awesome work on increasing coverage here!
|
As a side note, I wonder if we can add a more clear |
…for_path utility)
It would be nice, indeed. I'll try to dig into it :) |
Change Summary
Add a tiny case to increase coverage of
pydantic\aliases.pyto 100%.Tests for forbidden string indexing of
AliasPathargument via thesearch_dict_for_pathutility.note: I thought that the newly added assertions could fit into the existing
test_validation_alias_parse_data, therefore I didn't add a new test function. Happy to change if you think otherwise (or get guidance in any case)!Related issue number
Contributes to #7656.
Checklist