Enforce ruff/Pylint Refactor rules (PLR) #10459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic-documentation
topic-arrays
kmuehlbauer
reviewed
Jun 28, 2025
| f"To silence this warning remove 'original_shape' from encoding." | ||
| ) | ||
| char_dim_name = f"{char_dim_name}{strlen}" | ||
| elif ( |
Contributor
There was a problem hiding this comment.
@DimitriPapadopoulos Great to see this applied to the code base. One question, will this also be detected during pre-commit now?
Contributor
Author
There was a problem hiding this comment.
Yes, pre-commit runs ruff, which reads its configuration from pyproject.toml as usual.
PLR0124 Name compared with itself
PLR5501 Use `elif` instead of `else` then `if`, to reduce indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst