More f-strings, less format() #10505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
PYL-C0209
branch
from
87033b6 to
17e8ac6
Compare
DimitriPapadopoulos
force-pushed
the
PYL-C0209
branch
from
17e8ac6 to
bc7b88c
Compare
max-sixty
reviewed
Jul 5, 2025
| lhs = ",".join("({})".format(",".join(dims)) for dims in self.input_core_dims) | ||
| rhs = ",".join("({})".format(",".join(dims)) for dims in self.output_core_dims) | ||
| comma_separated = ",".join | ||
| lhs = comma_separated( |
Collaborator
There was a problem hiding this comment.
not sure this got simpler, but ok!
Contributor
Author
There was a problem hiding this comment.
Not sure either.
The only benefit might be that the intent shows clearly: separate with commas.
Collaborator
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rst