Skip to content

Conversation

@jemmajeffree
Copy link
Contributor

The first of the commits is most critical to closing #10568, later commits are just to smooth out the reader's experience. The biggest change is moving "Create a develoment environment" up to when it's first mentioned, otherwise the flow of the docs seems to involve skipping to a later section and then skipping back.

Also tidied up a hyperlink that seemed to unintentionally link to pandas, and another one that used a https webpage instead of an internal cross-reference

@ianhi

If the *xarray* ``main`` branch version has updated since you last fetched changes,
you may also wish to reinstall xarray so that the pip version reflects the *xarray*
version::
pip install -e .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need an extra line break before code here, which is why the doc build is failing:

/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/10576/doc/contribute/contributing.rst:282: ERROR: Unexpected indentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; it was skipping over the error and building locally, but I think it's not throwing the error any more

@shoyer shoyer merged commit 4d16307 into pydata:main Jul 29, 2025
37 checks passed
@welcome
Copy link

welcome bot commented Jul 29, 2025

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

@shoyer
Copy link
Member

shoyer commented Jul 29, 2025

Thank you, Jemma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribution guide instructions don't copy tags, which can be an issue for xarray version and other library's dependencies

2 participants