Synchronize mypy test requirements to 1.17.1 #10751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Automation
Collaborator
Collaborator
|
I'm going to try pushing to this branch |
- Add list-item to type ignore for df.columns assignment - Remove unnecessary attr-defined type ignores that mypy 1.17.1 now understands
Collaborator
|
ok, that should fix it, will leave you to merge @shoyer |
shoyer
added a commit
to shoyer/xarray
that referenced
this pull request
Sep 16, 2025
* Update mypy test requirement to 1.17.1 * Fix mypy 1.17.1 compatibility issues - Add list-item to type ignore for df.columns assignment - Remove unnecessary attr-defined type ignores that mypy 1.17.1 now understands * Restore type ignores needed by mypy 1.17.1 in CI environment --------- Co-authored-by: Maximilian Roos <[email protected]> Co-authored-by: Maximilian Roos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably won't pass, but at least it will make it more obvious what's going on!
cc @dcherian