Enable mypy type checking for xarray.tests.test_combine #10753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type annotations to satisfy mypy's check_untyped_defs requirement - Fix combine_nested type signature to accept None for concat_dim parameter - Add minimal type hints where mypy cannot infer types - No behavioral changes, all tests pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
shoyer
pushed a commit
to shoyer/xarray
that referenced
this pull request
Sep 16, 2025
- Add type annotations to satisfy mypy's check_untyped_defs requirement - Fix combine_nested type signature to accept None for concat_dim parameter - Add minimal type hints where mypy cannot infer types - No behavioral changes, all tests pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
xarray.tests.test_combinefrom the mypy exclusion listcheck_untyped_defsfor this test fileChanges
Noneforconcat_dim(matching runtime behavior)Notes
combine_nestedfunction already acceptedconcat_dim=Noneat runtime (converting it to[None]internally), so we just updated the type signature to reflect this🤖 Generated with Claude Code