This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Fixes Issue23812: asyncio.Queue task cancellation leads to item being lost #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lost asyncio.Queue.put_nowait(), followed get() task cancellation leads to item being lost. See http://bugs.python.org/issue23812
Member
|
@gjcarneiro Hi Gustavo, thanks for the PR. I've left a few comments there, please take a look. Overall, I like the patch, let's get this fixed finally. |
added 2 commits
August 5, 2015 17:14
1. only puts item back in the queue if waiter.done() is true 2. add comment explaining cancellation 3. Add a missing self._consume_done_getters() call
Author
|
@1st1 thanks for the review! The new commit should address those issues. Cheers. |
Member
|
@gjcarneiro Thanks, Gustavo! LGTM. @gvanrossum @Haypo I'm going to commit Gustavo's patch soon, unless you guys want to review it too. |
Member
|
I don't feel the need to review.
|
1st1
added a commit
that referenced
this pull request
Aug 5, 2015
Member
|
Merged. Thanks, @gjcarneiro. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.Queue.put_nowait(), followed get() task cancellation leads to item being
lost. See http://bugs.python.org/issue23812