Add support for _msi.Record.GetString() and _msi.Record.GetInteger()

[atuining]

BPO	1102
Nosy	@loewis, @tjguk, @berkerpeksag, @zware, @zooba
PRs	bpo-1102: View.Fetch() now returns None when it's exhausted #4459 [3.6] bpo-1102: View.Fetch() now returns None when it's exhausted (GH-4459) #4520
Files	_msi.patch.txt: Patch to fix fetching from views _msi_fetch.patch.txt: Simplified patch for fixing fetching from views (against 2.7.2)

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2017-11-23.14:34:19.799>
created_at = <Date 2007-09-04.21:01:54.634>
labels = ['3.7', 'type-bug', 'library', 'OS-windows']
title = 'Add support for _msi.Record.GetString() and _msi.Record.GetInteger()'
updated_at = <Date 2017-11-23.14:34:19.798>
user = 'https://bugs.python.org/atuining'

bugs.python.org fields:

activity = <Date 2017-11-23.14:34:19.798>
actor = 'berker.peksag'
assignee = 'loewis'
closed = True
closed_date = <Date 2017-11-23.14:34:19.799>
closer = 'berker.peksag'
components = ['Library (Lib)', 'Windows']
creation = <Date 2007-09-04.21:01:54.634>
creator = 'atuining'
dependencies = []
files = ['11840', '24795']
hgrepos = []
issue_num = 1102
keywords = ['patch']
message_count = 16.0
messages = ['55644', '67691', '67694', '75000', '138211', '138212', '155456', '220649', '225877', '226053', '306498', '306814', '306816', '306817', '306821', '306822']
nosy_count = 7.0
nosy_names = ['loewis', 'atuining', 'tim.golden', 'berker.peksag', 'zach.ware', 'steve.dower', 'uday kiran']
pr_nums = ['4459', '4520']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1102'
versions = ['Python 3.6', 'Python 3.7']

[atuining]

Attached is a patch that adds the requested support. This is in relation
to the thread at

http://www.gossamer-threads.com/lists/python/python/584264

In addition to the two methods I also "fixed" Fetch() by ensuring that
when the records are exhausted None is returned instead of an error.

If something further is required of me or I submitted this patch
incorrectly, please let me know so I don't screw it up next time. :-)

[atuining]

This patch appears to be mostly duplicated by patch 2125 which has been
accepted. Would it be helpful if I separated out the parts that have now
been accepted?

[loewis]

Yes, please do provide an updated patch.

[atuining]

With apologies for the delay, I have modified the patch to remove the
stuff that has been added already. Some of the other changes are to make
use of new C API functionality but they can be ignored, if desired. The
changes that are relevant are in the view_fetch() routine. Again, if you
have questions, let me know.

[terryjreedy]

Martin, would this go in a bugfix release or is it a new feature for 3.3 only?

[loewis]

I lost track what problem precisely this patch solves, so it's hard to tell whether it's a bug fix or not.

[atuining]

All, I have trimmed this patch down to the bare minimum required to solve this problem. Please review this as I would dearly love to have this committed. The error received without this patch is

MSIError: unknown error 103

This occurs when there are no more records to fetch from the view. The patch simply returns None when there are no more records to fetch -- similar to what is done by the DB API.

[BreamoreBoy]

Can someone review the latest patch please as it's only five additional lines of C code.

[atuining]

I note that this patch has still not been accepted! Please let me know what needs to be done. I just tried against Python 3.4 and the patch works as expected -- other than the starting line number is now 715. I have signed the contributor agreement if that is what is holding things up.