Remove deprecated items from asynchat

[lehmannro]

BPO	6916
Nosy	@birkenfeld, @rhettinger, @josiahcarlson, @vstinner, @giampaolo, @ezio-melotti, @berkerpeksag
Files	asynchat.patch: patch for asynchat.py and test/test_asynchat.py use-assertwarns.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/giampaolo'
closed_at = <Date 2014-07-07.22:41:49.801>
created_at = <Date 2009-09-15.05:55:55.402>
labels = ['easy', 'tests', 'type-feature', 'library', 'docs']
title = 'Remove deprecated items from asynchat'
updated_at = <Date 2014-07-09.00:12:40.978>
user = 'https://bugs.python.org/lehmannro'

bugs.python.org fields:

activity = <Date 2014-07-09.00:12:40.978>
actor = 'python-dev'
assignee = 'giampaolo.rodola'
closed = True
closed_date = <Date 2014-07-07.22:41:49.801>
closer = 'vstinner'
components = ['Documentation', 'Library (Lib)', 'Tests']
creation = <Date 2009-09-15.05:55:55.402>
creator = 'lehmannro'
dependencies = []
files = ['14894', '35722']
hgrepos = []
issue_num = 6916
keywords = ['patch', 'easy']
message_count = 16.0
messages = ['92645', '104286', '195470', '220507', '220558', '220559', '221132', '221143', '221160', '221173', '221174', '221188', '221246', '221255', '222531', '222593']
nosy_count = 11.0
nosy_names = ['georg.brandl', 'rhettinger', 'josiahcarlson', 'vstinner', 'giampaolo.rodola', 'lehmannro', 'ezio.melotti', 'docs@python', 'BreamoreBoy', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue6916'
versions = ['Python 3.5']

[lehmannro]

The patches in bpo-1736190 deprecated fifo and simple_producers. These
are safe for removal in Python 3.0.

I attached a patch purging fifo and simple_producers from py3k code and
tests. The docs are mostly trivial as well but also touched by my other
issue bpo-6911 so I'd like that to settle first, otherwise this might
result in a merge conflict.

[giampaolo]

I seem to remember that those classes were initially removed and then re-added by Josiah for backward compatibility (see discussions in bpo-1641 and bpo-1736190).

Despite practically useless after the changes applied to asynchat in Python 2.6, both classes are there since the very first checkin of asynchat.py, and the common policy in this case is to grant compatibility with older code, just in case few person out of many still rely on it.

I'd be more for stopping to mention them in the documentation, also because now that I look at it, the doc is wrong as it claims that "Each channel maintains a fifo" while this is no longer true since fifo() has been replaced by a deque().

[ezio-melotti]

What's the status of this?

[BreamoreBoy]

Is it worth the effort of committing changes like this when according to https://docs.python.org/3/library/asynchat.html#module-asynchat "This module exists for backwards compatibility only. For new code we recommend using asyncio."? See also bpo-6911.

[python-dev]

New changeset 42a645d74e9d by Giampaolo Rodola' in branch 'default':
fix issue bpo-6916: undocument deprecated asynchat.fifo class.q
http://hg.python.org/cpython/rev/42a645d74e9d

[giampaolo]

I simply removed asynchat.fifo documentation. Closing this out.