os.system() doesn't support surrogates nor bytes

[vstinner]

BPO	8412
Nosy	@vstinner
Files	os_system_surrogates.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-04-16.12:48:34.445>
created_at = <Date 2010-04-16.01:10:20.582>
labels = ['library', 'expert-unicode']
title = "os.system() doesn't support surrogates nor bytes"
updated_at = <Date 2010-04-16.12:48:34.444>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2010-04-16.12:48:34.444>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2010-04-16.12:48:34.445>
closer = 'vstinner'
components = ['Library (Lib)', 'Unicode']
creation = <Date 2010-04-16.01:10:20.582>
creator = 'vstinner'
dependencies = []
files = ['16941']
hgrepos = []
issue_num = 8412
keywords = ['patch']
message_count = 4.0
messages = ['103280', '103281', '103314', '103318']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue8412'
versions = ['Python 3.1', 'Python 3.2']

[vstinner]

os.system() doesn't support bytes, bytearray not str containing surrogates.

Attached patch uses PyUnicode_FSConverter, bytes2str and release_bytes in (the non-Windows version of) os.system() to support all of this. It locks the buffer because os.system() releases the GIL when calling system().

[vstinner]

See also bpo-8391 (os.execvpe env) and bpo-8393 (subprocess cwd).

[vstinner]

Commited to py3k as r80105. Let see if buildbots are happy or not :-)

[vstinner]

Commited to py3k as r80105

The buildbots look happy: backported to 3.1 as r80110.