zipimporter.find_module is untested

[alex]

BPO	8585
Nosy	@brettcannon, @terryjreedy, @ncoghlan, @rbtcollins, @alex, @berkerpeksag
Files	issue8585.diff Issue8585.patch: Original patch no longer applied

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2015-07-22.14:59:24.341>
created_at = <Date 2010-05-01.01:15:35.650>
labels = ['type-bug', 'tests']
title = 'zipimporter.find_module is untested'
updated_at = <Date 2015-07-22.14:59:24.338>
user = 'https://github.com/alex'

bugs.python.org fields:

activity = <Date 2015-07-22.14:59:24.338>
actor = 'rbcollins'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2015-07-22.14:59:24.341>
closer = 'rbcollins'
components = ['Tests']
creation = <Date 2010-05-01.01:15:35.650>
creator = 'alex'
dependencies = []
files = ['28033', '35826']
hgrepos = []
issue_num = 8585
keywords = ['patch']
message_count = 8.0
messages = ['104684', '113041', '113043', '175776', '175906', '222080', '247124', '247126']
nosy_count = 8.0
nosy_names = ['brett.cannon', 'terry.reedy', 'ncoghlan', 'rbcollins', 'alex', 'BreamoreBoy', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8585'
versions = ['Python 3.6']

[alex]

There are no tests for zipimporter.find_module in the success case, only tests that it handles invalid inputs ok. I'll work up some tests for this tomorrow probably.

[terryjreedy]

Since devs are trying to improve tests, I expect a patch will get looked at.

[alex]

Gah, I lost track of this one after I realized the bug I was chasing after (originally thought to be in PyPy's zipimpoter) was actually in Django. I'll try to get to this over the weekend.

[brettcannon]

Been longer than a weekend. =)

[berkerpeksag]

I've attached a patch that adds tests for the zipimporter.find_module().

[BreamoreBoy]

I've just reworked Berker's patch as it no longer applied. On Windows 7 before and after applying the patch both test runs gave me 49 tests, 2 skipped. Can we have a commit review please.

[python-dev]

New changeset ef5c5a2bbd48 by Robert Collins in branch 'default':
Issue bpo-8585: improved tests for zipimporter2. Patch from Mark Lawrence.
https://hg.python.org/cpython/rev/ef5c5a2bbd48

[rbtcollins]

Applied to 3.6 only.