test_urllib2net is triggering a ResourceWarning

[brettcannon]

BPO	12692
Nosy	@brettcannon, @orsenthil, @vadmium

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2012-10-21.15:45:23.457>
created_at = <Date 2011-08-05.05:02:31.361>
labels = ['tests', 'performance']
title = 'test_urllib2net is triggering a ResourceWarning'
updated_at = <Date 2013-12-29.01:38:25.307>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2013-12-29.01:38:25.307>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2012-10-21.15:45:23.457>
closer = 'nadeem.vawda'
components = ['Tests']
creation = <Date 2011-08-05.05:02:31.361>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 12692
keywords = []
message_count = 7.0
messages = ['141645', '141649', '141673', '173459', '207055', '207060', '207061']
nosy_count = 5.0
nosy_names = ['brett.cannon', 'orsenthil', 'nadeem.vawda', 'python-dev', 'martin.panter']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue12692'
versions = ['Python 3.2', 'Python 3.3']

[brettcannon]

Specifically, test.test_urllib2net.OtherNetworkTests.test_sites_no_connection_close is leaving a socket open somewhere, but tracking down exactly whom is to blame is a mess since socket.SocketIO.close() explicitly relies on refcounting to shut down a socket.

[nadeemvawda]

Relevant: http://mail.python.org/pipermail/python-dev/2011-July/112551.html

[brettcannon]

Thanks for the info, Nadeem.

[python-dev]

New changeset 92656b5df2f2 by Nadeem Vawda in branch 'default':
Issue bpo-12692: Fix resource leak in urllib.request.
http://hg.python.org/cpython/rev/92656b5df2f2

[vadmium]

Any chance of backporting this to version 3.3? I think it is a real-world issue beyond the test suite. See bpo-19524.

[python-dev]

New changeset a43e96695203 by Senthil Kumaran in branch '3.3':
Backporing the fix from Issue bpo-12692
http://hg.python.org/cpython/rev/a43e96695203

New changeset 031417ee8351 by Senthil Kumaran in branch 'default':
bpo-12692: null merge with 3.3
http://hg.python.org/cpython/rev/031417ee8351

[orsenthil]

@martin. Agree that this should have been backported. I have done that.
Thank you!