Use shutil.move instead of os.rename in packaging

[nvetoshkin]

BPO	14848
Nosy	@tarekziade, @merwok

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-03-13.08:34:46.166>
created_at = <Date 2012-05-18.08:50:31.624>
labels = []
title = 'Use shutil.move instead of os.rename in packaging'
updated_at = <Date 2014-03-13.08:34:46.165>
user = 'https://bugs.python.org/nvetoshkin'

bugs.python.org fields:

activity = <Date 2014-03-13.08:34:46.165>
actor = 'eric.araujo'
assignee = 'alexis'
closed = True
closed_date = <Date 2014-03-13.08:34:46.166>
closer = 'eric.araujo'
components = ['Distutils2']
creation = <Date 2012-05-18.08:50:31.624>
creator = 'nvetoshkin'
dependencies = []
files = []
hgrepos = []
issue_num = 14848
keywords = []
message_count = 7.0
messages = ['161042', '161052', '161053', '162572', '162751', '162753', '162755']
nosy_count = 4.0
nosy_names = ['tarek', 'eric.araujo', 'nvetoshkin', 'alexis']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue14848'
versions = ['3rd party', 'Python 3.3']

[nvetoshkin]

When I attempt to remove package with pysetup remove 'package-name' on Fedora 17 - it fails with:
'my-package' cannot be removed
Error: [Errno 18] Invalid cross-device link

strace'ing showed that there was an attempt to call rename from package dir into /tmp which is tmpfs.

Proposed fix is trivial - use shutil.move instead of barebone os.rename.

[merwok]

How did you install my-package?

[nvetoshkin]

pysetup install.
strace of removal looks like this:
stat("/home/nekto0n/workspace/pillar/penv/lib/python2.7/site-packages/ygroup/init.py", {st_mode=S_IFREG|0664, st_size=0, ...}) = 0
rename("/home/nekto0n/workspace/pillar/penv/lib/python2.7/site-packages/ygroup/init.py", "/tmp/ygroup-client-uninstalljkoIAl/init.py") = -1 EXDEV (Invalid cross-device link)

[merwok]

OK. Can you paste the full traceback for the error?

[nvetoshkin]

Sorry, no traceback by default, had to augment with "raise" :) Now output looks like this:

nekto0n@ya-darkstar /var/tmp/mypackage $ pysetup remove pygraphviz
u'workflow': u'1.01' is not a valid version (field 'Version')
u'zc-zookeeper-static': u'3.4.3-3' is not a valid version (field 'Version')
u'virtkey': u'0.01' is not a valid version (field 'Version')
u'SSSDConfig': u'1' is not a valid version (field 'Version')
[Errno 18] Invalid cross-device link
Traceback (most recent call last):
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", line 651, in main
    return dispatcher()
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", line 639, in __call__
    return func(self, self.args)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", line 91, in wrapper
    return f(*args, **kwargs)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", line 239, in _remove
    remove(dist, auto_confirm=auto_confirm)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/install.py", line 413, in remove
    error = _move_file(file_, tmpfile)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/install.py", line 399, in _move_file
    os.rename(source, target)
OSError: [Errno 18] Invalid cross-device link

According to strace arguments to rename where:
rename("/home/nekto0n/.local/lib/python2.7/site-packages/pygraphviz-1.1-py2.7.egg-info/PKG-INFO", "/tmp/pygraphviz-uninstallIiAQ1I/PKG-INFO") = -1 EXDEV (Invalid cross-device link)

[merwok]

Thanks! As your message shows the problem is in the install module, I propose to close this bug as a duplicate of Alexis’ bug about improving d2.install. The new FileMover class should use shutil.move, and we’ll make sure to test install+remove as you did to see if the bug is gone.

[nvetoshkin]

glad to help