PEP 3121, 384 refactoring applied to curses_panel module

[RobinSchreiber]

BPO	14936
Nosy	@loewis, @serhiy-storchaka
Files	curses_panel_pep384.patch curses_panel_pep3121.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-06-14.14:11:00.624>
created_at = <Date 2012-05-28.16:44:29.676>
labels = ['extension-modules', 'type-feature']
title = 'PEP 3121, 384 refactoring applied to curses_panel module'
updated_at = <Date 2016-05-08.18:35:54.408>
user = 'https://bugs.python.org/RobinSchreiber'

bugs.python.org fields:

activity = <Date 2016-05-08.18:35:54.408>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2012-06-14.14:11:00.624>
closer = 'loewis'
components = ['Extension Modules']
creation = <Date 2012-05-28.16:44:29.676>
creator = 'Robin.Schreiber'
dependencies = []
files = ['25746', '25747']
hgrepos = []
issue_num = 14936
keywords = ['patch']
message_count = 5.0
messages = ['161793', '161794', '162790', '162791', '265155']
nosy_count = 4.0
nosy_names = ['loewis', 'python-dev', 'serhiy.storchaka', 'Robin.Schreiber']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14936'
versions = ['Python 3.3']

[RobinSchreiber]

I have now applied the Heap-Type Refactoring from PEP-384 to the curses_panel module. Currently I still provide seperate patches for the PEP-3121 and PEP-384 refactoring. As mentioned in Issue bpo-14935 I am planning to release single patches in the future for each module I refactor.

[RobinSchreiber]

I have now also added the PEP-3121 patch for the curses_panel module.

[python-dev]

New changeset 9a6b45a83dec by Martin v. Löwis in branch 'default':
Issue bpo-14936: curses_panel was converted to PEP-3121 API.
http://hg.python.org/cpython/rev/9a6b45a83dec

New changeset 6eb21c1d3099 by Martin v. Löwis in branch 'default':
Issue bpo-14936: curses_panel was converted to PEP-3121 and PEP-384 API.
http://hg.python.org/cpython/rev/6eb21c1d3099

[loewis]

Thanks for the patches!

[serhiy-storchaka]

This patch made the "_curses_panel.curses panel" type callable. Created objects were in inconsistent state and using them caused a crash.

This bug is fixed in bpo-23815. Opened bpo-26979 for documenting the catch.