PEP 3121, 384 Refactoring applied to tkinter module

[RobinSchreiber]

BPO	15721
Nosy	@loewis, @amauryfa, @pitrou, @ned-deily, @asvetlov, @serhiy-storchaka
Files	_tkinter_pep3121-384_v0.patch _tkinter_pep3121-384_v1.patch _tkinter_pep3121-384_v2.patch _tkinter_pep3121-384_v3.patch _tkinter_pep3121-384_v4.patch _tkinter_pep3121-384_v7.patch _tkinter_pep384_v1.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/asvetlov'
closed_at = <Date 2016-05-08.18:31:21.213>
created_at = <Date 2012-08-18.10:53:44.006>
labels = ['extension-modules', 'performance']
title = 'PEP 3121, 384 Refactoring applied to tkinter module'
updated_at = <Date 2016-05-08.18:31:21.212>
user = 'https://bugs.python.org/RobinSchreiber'

bugs.python.org fields:

activity = <Date 2016-05-08.18:31:21.212>
actor = 'serhiy.storchaka'
assignee = 'asvetlov'
closed = True
closed_date = <Date 2016-05-08.18:31:21.213>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2012-08-18.10:53:44.006>
creator = 'Robin.Schreiber'
dependencies = []
files = ['26887', '27457', '27458', '27460', '27464', '27470', '27475']
hgrepos = []
issue_num = 15721
keywords = ['pep3121']
message_count = 24.0
messages = ['168504', '168505', '168522', '172210', '172213', '172222', '172230', '172245', '172248', '172257', '172288', '172306', '172883', '172969', '172985', '174226', '174227', '187261', '187380', '194842', '194843', '231696', '254680', '265154']
nosy_count = 8.0
nosy_names = ['loewis', 'amaury.forgeotdarc', 'pitrou', 'ned.deily', 'asvetlov', 'python-dev', 'serhiy.storchaka', 'Robin.Schreiber']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue15721'
versions = ['Python 3.4']

[RobinSchreiber]

Changes proposed in PEP-3121 and PEP-384 have now been applied to the tkinter module!
When running the test form inside Python.exe (tkinter._test()), the litte "test-window" is rendered correctly. However there are still some error messages popping up inside the python shell
(I am running this on OS X 10.8):

>>> tkinter._test()
2012-08-18 12:46:24.775 python.exe[17410:707] speedup (null)
2012-08-18 12:46:24.776 python.exe[17410:707] ERROR: Unable to find method [_NSFullScreenTransition _startFullScreenTransitionForCGWindow:targetFrame:duration:].
2012-08-18 12:46:24.776 python.exe[17410:707] ERROR: Unable to find method [_NSFullScreenTransition _startEnterFullScreenTransitionForCGWindow:targetFrame:duration:].
2012-08-18 12:46:24.778 python.exe[17410:707] ERROR: Unable to find method [_NSFullScreenTransition startExitFullScreenTransitionForCGWindow:targetFrame:duration:].
[87221 refs]
>>> 

I have no Idea how and where these are triggered.

[loewis]

See

http://www.python.org/download/mac/tcltk/

It may be that using a different build of Tcl/Tk solves that problem.

[ned-deily]

What version of 10.8 are you seeing those messages with? And do you see them without the patch applied?

[asvetlov]

Update patch conforming to current _tkinter code.

[asvetlov]

I would to have all module state inside _tkinterstate structure.
static variables like tcl_lock, tcl_state, quitMainLoop, errorInCmd etc should be moved into _tkinterstate also.

[RobinSchreiber]

Before I submitted this patch, I used to have these variables inside the modulestate, which caused severe problems. I do not know the exact reason, but my guess is that these variables have to be globally available for every thread (tcl variables are used for thread synchronization arent they?). As the modulestate may change depending on the thread, one can no longer guarantee that every thread within the process is operating on the same variable. This might not be nessecary, however as I mentioned, the naive approach of putting the variables inside the modulestate did not work out for me.

[asvetlov]

I'm trying to make patch following myself recommendations.
Looks good but not finished yet. Will publish it after all work done.

[asvetlov]

Submit patch which store own state into module state.
Still not finished yet: need to add checks for "ready state" in every access to fields of module state structure.

[asvetlov]

Update patch to support TKINTER_PROTECT_LOADTK option.

[asvetlov]

Upload version which check if _tkinter module was destroyed (for example, if it was call from daemon thread runing Tk app when main thread is exiting with interpreter finalization).

[asvetlov]

The patch for current default branch.

[asvetlov]

The patch is huge, then I like to apply it in two steps: first implement PEP-384 than 3121.
Attached first patch.