cookielib.http2time raises ValueError for invalid date.

[CharlesJones]

BPO	16181
Nosy	@berkerpeksag
Files	issue16181_v1.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-03-14.03:49:11.347>
created_at = <Date 2012-10-09.20:06:52.264>
labels = ['type-bug', 'library']
title = 'cookielib.http2time raises ValueError for invalid date.'
updated_at = <Date 2016-03-14.03:49:11.278>
user = 'https://bugs.python.org/CharlesJones'

bugs.python.org fields:

activity = <Date 2016-03-14.03:49:11.278>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-14.03:49:11.347>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2012-10-09.20:06:52.264>
creator = 'Charles.Jones'
dependencies = []
files = ['29140']
hgrepos = []
issue_num = 16181
keywords = ['patch']
message_count = 4.0
messages = ['172515', '182582', '220640', '261721']
nosy_count = 4.0
nosy_names = ['BreamoreBoy', 'python-dev', 'berker.peksag', 'Charles.Jones']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16181'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[CharlesJones]

The docs for http2time state that "None is returned if [...] the time is outside the representable range". However, it is raising a ValueError when a year larger than datetime.MAXYEAR is provided (actually raised downstream by calendar.date()).

To reproduce:
import cookielib
print cookielib.http2time("08-Oct-3697739")

Expected Result:
Should return None

Actual Result:
Raises ValueError: year is out of range

[berkerpeksag]

Patch attached with a test.

[BreamoreBoy]

A simple patch is attached so could someone take a look please, thanks.

[python-dev]

New changeset 838f68a76ea1 by Berker Peksag in branch '3.5':
Issue bpo-16181: cookiejar.http2time() now returns None if year is higher than datetime.MAXYEAR
https://hg.python.org/cpython/rev/838f68a76ea1

New changeset 8b7de03261f5 by Berker Peksag in branch 'default':
Issue bpo-16181: cookiejar.http2time() now returns None if year is higher than datetime.MAXYEAR
https://hg.python.org/cpython/rev/8b7de03261f5