Support xz compression in distutils

[serhiy-storchaka]

BPO	16314
Nosy	@tarekziade, @jwilk, @ned-deily, @merwok, @serhiy-storchaka
Files	distutils-lzma.patch distutils-lzma_2.patch distutils-lzma_3.patch distutils-lzma_4.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2015-05-19.11:13:53.289>
created_at = <Date 2012-10-24.21:32:58.586>
labels = ['type-feature', 'library']
title = 'Support xz compression in distutils'
updated_at = <Date 2015-05-19.11:13:53.288>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2015-05-19.11:13:53.288>
actor = 'serhiy.storchaka'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2015-05-19.11:13:53.289>
closer = 'serhiy.storchaka'
components = ['Distutils']
creation = <Date 2012-10-24.21:32:58.586>
creator = 'serhiy.storchaka'
dependencies = []
files = ['27704', '38564', '38648', '38887']
hgrepos = []
issue_num = 16314
keywords = ['patch', 'needs review']
message_count = 13.0
messages = ['173708', '173709', '173714', '210790', '224472', '238527', '238539', '238991', '240256', '240411', '243361', '243377', '243378']
nosy_count = 8.0
nosy_names = ['nadeem.vawda', 'tarek', 'jwilk', 'ned.deily', 'eric.araujo', 'Arfrever', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16314'
versions = ['Python 3.5']

[serhiy-storchaka]

The proposed patch adds xz compression support in additional to gzip, compress and bzip2 in distutils.

[merwok]

I think there’s already a report for distutils2.

For distutils, if we take the feature freeze seriously, this would have to be rejected. I know it looks innocuous, but distutils is brittle code widely monkey-patched, so I prefer to take no chances.

[serhiy-storchaka]

OK, I didn't know that distutils are frozen.

[Arfrever]

AFAIK distutils is no longer frozen.

[serhiy-storchaka]

What about the patch?

[merwok]

Code and doc changes look good. Will you add tests?

[serhiy-storchaka]

Added tests for gztar, bztar and xztar. Added more asserts in other tests.

[serhiy-storchaka]

Addressed Berker's comments. Added versionchanged directives and a whatsnews entry.

[serhiy-storchaka]

Ping.