uuid.getnode() MAC address on AIX

[aivarsk]

BPO	17293
Nosy	@vstinner, @serhiy-storchaka, @koobs, @xnox
Files	aix_mac.patch uuid_netstat_getnode.patch uuid_netstat_getnode-3.5.patch uuid_netstat_getnode-3.5_2.patch uuid_netstat_getnode-3.4.patch koobs-freebsd10-python27-build758.log uuid_arp_getnode_freebsd.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-11-27.22:52:52.862>
created_at = <Date 2013-02-25.07:29:08.128>
labels = ['type-bug', 'library']
title = 'uuid.getnode() MAC address on AIX'
updated_at = <Date 2015-01-05.17:55:00.193>
user = 'https://bugs.python.org/aivarsk'

bugs.python.org fields:

activity = <Date 2015-01-05.17:55:00.193>
actor = 'xnox'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-11-27.22:52:52.862>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-02-25.07:29:08.128>
creator = 'aivarsk'
dependencies = []
files = ['29229', '36768', '36993', '36998', '36999', '37193', '37196']
hgrepos = []
issue_num = 17293
keywords = ['patch']
message_count = 27.0
messages = ['182925', '223390', '223693', '223705', '223724', '223738', '228108', '229151', '229153', '229154', '229160', '229162', '229163', '229172', '229831', '229832', '229833', '229866', '230784', '230817', '231148', '231176', '231225', '231242', '231264', '231494', '233473']
nosy_count = 9.0
nosy_names = ['vstinner', 'neologix', 'BreamoreBoy', 'python-dev', 'serhiy.storchaka', 'koobs', 'aivarsk', 'xnox', 'David.Edelsohn']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17293'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[aivarsk]

uuid.getnode() on AIX returned random integer. This patch finds MAC in output of netstat -ia.
Tested on AIX 5.2

[BreamoreBoy]

@aivars sorry about the delay in getting back to you.

[neologix]

Thanks for the patch, but I'm not even sure AIX is an officially supported platform, so I'm not sure what to do with this patch.

[DavidEdelsohn]

Huh? What does officially supported platform mean? CPython builds and runs on AIX.

[neologix]

Huh? What does officially supported platform mean? CPython builds and runs on AIX.

It means a platform for which we have regular contributors committed
to support the port, and ideallly with a stable buildbot.

We apparently have an unstable buildbot with mainy tests failing (and
last time I checked it didn't even build IIRC))
http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/

So it would be nice to have the full regtest pass (with skips if applicable).

[BreamoreBoy]

David is listed against AIX on the experts list https://docs.python.org/devguide/experts.html. That alone suggests to me that AIX is an officially supported platform.

[serhiy-storchaka]

Thank you Aivars for your patch. I have verified and confirm that this method works on AIX and True64 UNIX (it should also work on IRIX, but I can't login in Snakebite's i6).

Here is modified patch. MAC address is now searched only in column with the "Address" header. Added try/except around converting to int for the case if candidate word contains non-heximal digits. Synchronized _netstat_getnode() with current code of _find_mac and extracted common code in separate function. Split _ifconfig_getnode() into separate functions which use different commands: ifconfig, arp and lanscan.

[serhiy-storchaka]

If there are no objections, I'll commit the patch soon.

[neologix]

My only comment would be to use subprocess instead of os.popen().

[serhiy-storchaka]

This is different issue and can be applied only to 3.5.

[neologix]

Why is that a different issue?
The code you *add in this patch* uses os.popen, why not use subprocess instead?

Furthermore, the code catches OSError when calling popen(), but
popen() doesn't raise an exception.

[vstinner]

FYI os.popen() now calls subprocess... So it's safe to call directly subprocess.