mingw: add wincrypt.h in Python/random.c

[rpetrov]

BPO	17596
Nosy	@pfmoore, @pitrou, @tjguk, @vadmium, @zware, @zooba, @moreati
Files	0007-MINGW-add-wincrypt.h-in-Python-random.c.patch 0006-MINGW-add-wincrypt.h-in-Python-random.c.patch: status on 2014-08-02 MINGW-wincrypt.v3.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-07-29.04:13:30.123>
created_at = <Date 2013-03-31.19:52:30.075>
labels = ['type-feature', 'OS-windows', 'build']
title = 'mingw: add wincrypt.h in Python/random.c'
updated_at = <Date 2016-07-29.04:13:30.122>
user = 'https://bugs.python.org/rpetrov'

bugs.python.org fields:

activity = <Date 2016-07-29.04:13:30.122>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-07-29.04:13:30.123>
closer = 'martin.panter'
components = ['Build', 'Windows', 'Cross-Build']
creation = <Date 2013-03-31.19:52:30.075>
creator = 'rpetrov'
dependencies = []
files = ['29629', '36220', '42111']
hgrepos = []
issue_num = 17596
keywords = ['patch']
message_count = 6.0
messages = ['185656', '185672', '261489', '271599', '271600', '271601']
nosy_count = 9.0
nosy_names = ['paul.moore', 'pitrou', 'tim.golden', 'rpetrov', 'python-dev', 'martin.panter', 'zach.ware', 'steve.dower', 'Alex.Willmer']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17596'
versions = ['Python 3.6']

[rpetrov]

split of bpo-3871

[pitrou]

Why the "#ifdef __MINGW32__"? I suppose the include is harmless anyway.

[vadmium]

Yes I would tend to think including <wincrypt.h> would be harmless on Windows, but I don’t have a native Windows to try it out on. Here is a proposed patch anyway. It would be good for someone to be able to confirm it doesn’t break the normal Windows build.

[vadmium]

I think this one should be fairly safe; any breakage should be pretty obvious by watching the buildbots.

[python-dev]

New changeset 11ed7c49f5df by Martin Panter in branch 'default':
Issue bpo-17596: MINGW: add wincrypt.h in Python/random.c
https://hg.python.org/cpython/rev/11ed7c49f5df

[vadmium]

For the record, the first error without this patch is

../Python/random.c:26:1: error: unknown type name 'HCRYPTPROV'

According to <https://msdn.microsoft.com/en-us/library/windows/desktop/aa382471%28v=vs.85%29.aspx\>, the header to use is <Wincrypt.h>, but we use lowercase <wincrypt.h> to avoid a problem with case sensitivity.