put opcode information in one place

[benjaminp]

BPO	17861
Nosy	@loewis, @Yhg1s, @db3l, @vstinner, @benjaminp, @ned-deily, @ezio-melotti, @merwok, @serhiy-storchaka, @kushaldas
Files	generate_opcode_h.py: opcode.h generator generate_opcode_h.py: second version of the patch generate_opcode_h.py: Third revision of the patch. issue17861_v1.patch: patch with code and makefile update issue17861_v2.patch: version two of the patch issue17861_v3.patch: New patch with .hgtouch file details. issue17861_v4.patch: New patch with proper changesets. issue17861_v5.patch: New patch from a clean repo, with changed opcode.h issue17861_v6.patch: New patch with changes as suggested by Brett. generate_opcode_h.diff generate_opcode_h.diff: Support running under Python 2.5

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kushaldas'
closed_at = <Date 2018-04-06.23:51:26.582>
created_at = <Date 2013-04-28.15:14:49.574>
labels = ['interpreter-core', 'easy', 'type-feature']
title = 'put opcode information in one place'
updated_at = <Date 2018-04-06.23:51:26.582>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2018-04-06.23:51:26.582>
actor = 'ned.deily'
assignee = 'kushal.das'
closed = True
closed_date = <Date 2018-04-06.23:51:26.582>
closer = 'ned.deily'
components = ['Interpreter Core']
creation = <Date 2013-04-28.15:14:49.574>
creator = 'benjamin.peterson'
dependencies = []
files = ['30045', '30046', '30048', '30064', '30066', '34842', '34855', '34872', '34883', '34930', '35078']
hgrepos = []
issue_num = 17861
keywords = ['patch', 'easy']
message_count = 22.0
messages = ['187986', '187998', '188000', '188005', '188074', '188079', '215915', '216004', '216179', '216233', '216294', '216348', '216358', '216591', '216599', '216620', '217409', '217415', '217417', '217469', '217500', '314258']
nosy_count = 11.0
nosy_names = ['loewis', 'twouters', 'db3l', 'vstinner', 'benjamin.peterson', 'ned.deily', 'ezio.melotti', 'eric.araujo', 'python-dev', 'serhiy.storchaka', 'kushal.das']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17861'
versions = ['Python 3.4']

[benjaminp]

Right now, opcode information is duplicated in Include/opcode.h and Lib/opcode.py. I should only have to update one manually and have the other one generated automatically. opcode.h should probably be generated by a script from opcode.py.

[kushaldas]

Here is a simple script which prints the opcode.h in console. We can redirect it as required.

[kushaldas]

Second version of the script with the fix for HAVE_ARGUMENT

[kushaldas]

Third revision with fixed empty spaces at the end of the lines.

[kushaldas]

As we discussed on #python-dev channel this new patch includes the script in Tools/scripts/generate_opcode_h.py and it also contains the required Makefile.pre.in change so that it gets auto(re)generated at compile time if required.

[kushaldas]

Version 2 of the patchset edited as per review.

[merwok]

Patch looks good to me.

[loewis]

Please add the file to .hgtouch as well, and verify that "make touch" works correctly.

[kushaldas]

New patch with .hgtouch file details.

[kushaldas]

New patch with proper changesets.

[kushaldas]

New patch from a clean repo, with changed opcode.h

[kushaldas]

New patch with changes as suggested by Brett.